lkml.org 
[lkml]   [2014]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.16 050/357] i2c: rcar: fix RCAR_IRQ_ACK_{RECV|SEND}
    Date
    3.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

    commit 938916fbb8e8cb67eacb784f4eda17e2950c16c5 upstream.

    Bits 8-31 of all registers reflect the value of bits 0-7 on reads and should be
    0 on writes, according to the manuals. RCAR_IRQ_ACK_{RECV|SEND} macros have all
    1's in bits 8-31, thus going against the manuals, so fix them.

    Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
    Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/i2c/busses/i2c-rcar.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/i2c/busses/i2c-rcar.c
    +++ b/drivers/i2c/busses/i2c-rcar.c
    @@ -76,8 +76,8 @@
    #define RCAR_IRQ_RECV (MNR | MAL | MST | MAT | MDR)
    #define RCAR_IRQ_STOP (MST)

    -#define RCAR_IRQ_ACK_SEND (~(MAT | MDE))
    -#define RCAR_IRQ_ACK_RECV (~(MAT | MDR))
    +#define RCAR_IRQ_ACK_SEND (~(MAT | MDE) & 0xFF)
    +#define RCAR_IRQ_ACK_RECV (~(MAT | MDR) & 0xFF)

    #define ID_LAST_MSG (1 << 0)
    #define ID_IOERROR (1 << 1)



    \
     
     \ /
      Last update: 2014-10-04 03:21    [W:4.098 / U:1.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site