lkml.org 
[lkml]   [2014]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.16 196/357] gpio / ACPI: Use pin index and bit length
    Date
    3.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

    commit c15d821ddb9dac9ac6b5beb75bf942f3bc3a4004 upstream.

    Fix code when the operation region callback is for an gpio, which
    is not at index 0 and for partial pins in a GPIO definition.
    For example:
    Name (GMOD, ResourceTemplate ()
    {
    //3 Outputs that define the Power mode of the device
    GpioIo (Exclusive, PullDown, , , , "\\_SB.GPI2") {10, 11, 12}
    })
    }

    If opregion callback calls is for:
    - Set pin 10, then address = 0 and bit length = 1
    - Set pin 11, then address = 1 and bit length = 1
    - Set for both pin 11 and pin 12, then address = 1, bit length = 2

    This change requires updated ACPICA gpio operation handler code to
    send the pin index and bit length.

    Fixes: 473ed7be0da0 (gpio / ACPI: Add support for ACPI GPIO operation regions)
    Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
    Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
    Acked-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpio/gpiolib-acpi.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- a/drivers/gpio/gpiolib-acpi.c
    +++ b/drivers/gpio/gpiolib-acpi.c
    @@ -357,8 +357,10 @@ acpi_gpio_adr_space_handler(u32 function
    struct gpio_chip *chip = achip->chip;
    struct acpi_resource_gpio *agpio;
    struct acpi_resource *ares;
    + int pin_index = (int)address;
    acpi_status status;
    bool pull_up;
    + int length;
    int i;

    status = acpi_buffer_to_resource(achip->conn_info.connection,
    @@ -380,7 +382,8 @@ acpi_gpio_adr_space_handler(u32 function
    return AE_BAD_PARAMETER;
    }

    - for (i = 0; i < agpio->pin_table_length; i++) {
    + length = min(agpio->pin_table_length, (u16)(pin_index + bits));
    + for (i = pin_index; i < length; ++i) {
    unsigned pin = agpio->pin_table[i];
    struct acpi_gpio_connection *conn;
    struct gpio_desc *desc;



    \
     
     \ /
      Last update: 2014-10-04 03:01    [W:4.258 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site