lkml.org 
[lkml]   [2014]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 05/11] irqchip: bcm7120-l2: Make sure all register accesses use base+offset
Date
On Wednesday 29 October 2014 08:46:00 Arnd Bergmann wrote:
> On Tuesday 28 October 2014 20:58:52 Kevin Cernekee wrote:
> >
> > irq_gc_lock(gc);
> > /* Save the current mask and the interrupt forward mask */
> > - b->saved_mask = __raw_readl(b->base) | b->irq_fwd_mask;
> > + b->saved_mask = __raw_readl(b->base + IRQEN) | b->irq_fwd_mask;
> > if (b->can_wake) {
> > reg = b->saved_mask | gc->wake_active;
> > - __raw_writel(reg, b->base);
> > + __raw_writel(reg, b->base + IRQEN);
> > }
> > irq_gc_unlock(gc);
> > }
> > @@ -81,7 +81,7 @@ static void bcm7120_l2_intc_resume(struct irq_data *d)
> >
> > /* Restore the saved mask */
> > irq_gc_lock(gc);
> > - __raw_writel(b->saved_mask, b->base);
> > + __raw_writel(b->saved_mask, b->base + IRQEN);
> > irq_gc_unlock(gc);
> >
>
> You should really change this one too, to use fixed-endian accessors.
> __raw_writel can't safely be used in drivers, and it will break
> big-endian kernels running on ARM BRCMSTB.

As you already fix this in patch 6, please disregard my comment above,
your patch looks ok.

Acked-by: Arnd Bergmann <arnd@arndb.de>


\
 
 \ /
  Last update: 2014-10-29 09:01    [W:0.052 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site