Messages in this thread | | | Date | Wed, 29 Oct 2014 15:03:15 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [RFA][PATCH 8/8] debugfs: Have debugfs_print_regs32() return void |
| |
On Wed, Oct 29, 2014 at 05:56:10PM -0400, Steven Rostedt wrote: > From: Joe Perches <joe@perches.com> > > [ REQUEST FOR ACKS ] > > The seq_printf() will soon just return void, and seq_has_overflowed() > should be used instead to see if the seq can no longer accept input. > > As the return value of debugfs_print_regs32() has no users and > the seq_file descriptor should be checked with seq_has_overflowed() > instead of return values of functions, it is better to just have > debugfs_print_regs32() also return void. > > Link: http://lkml.kernel.org/p/2634b19eb1c04a9d31148c1fe6f1f3819be95349.1412031505.git.joe@perches.com > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Joe Perches <joe@perches.com> > [ original change only updated seq_printf() return, added return of > void to debugfs_print_regs32() as well ] > Signed-off-by: Steven Rostedt <rostedt@goodmis.org> > ---
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| |