lkml.org 
[lkml]   [2014]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/3] char: misc: assign file->private_data to miscdevice on open
Date
This slightly changes the behaviour of miscdevice drivers at an open()
syscall. Not only if the driver happens to implement an open() fop itself,
but now just always file->private_data points to struct miscdevice, when
a user opens the device file.

This call for review once more: if anybody has an hour to kill:

Look for the only dangerous situation where a miscdevice driver _depends_ on
file->private_data being NULL when _not_ implementing an open() routine
itself. I didn't find anything.

The one section I was unsure about should be ok, see
http://marc.info/?l=linux-kernel&m=141376535132316&w=2

Bonus: one could look for drivers that _do_ implement open()
and do the (in any case) redundant work themselves.

Martin Kepplinger (3):
misc: always assign miscdevice to file->private_data in open()
fbdev: pxa3xx-gcu: remove redundant implementation of open()
char: misc: document behaviour of open()

drivers/char/misc.c | 6 ++++--
drivers/video/fbdev/pxa3xx-gcu.c | 10 ----------
2 files changed, 4 insertions(+), 12 deletions(-)

--
1.7.10.4



\
 
 \ /
  Last update: 2014-10-29 21:01    [W:0.039 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site