Messages in this thread | | | Date | Wed, 29 Oct 2014 20:12:49 +0100 | Subject | Re: [PATCH] CodingStyle: Add a chapter on conditional compilation | From | Geert Uytterhoeven <> |
| |
On Wed, Oct 29, 2014 at 7:15 PM, Josh Triplett <josh@joshtriplett.org> wrote: > Document several common practices and conventions regarding conditional > compilation, most notably the preference for ifdefs in headers rather > than .c files. > > Signed-off-by: Josh Triplett <josh@joshtriplett.org>
> +If you have a function or variable which may potentially go unused in a > +particular configuration, and the compiler would warn about its definition > +going unused, mark the definition as __maybe_unused rather than wrapping it in > +a preprocessor conditional. (However, if a function or variable *always* goes > +unused, delete it.)
Personally, I don't like __maybe_unused. Once it's there, the compiler will stop warning about it, even if it really becomes unused.
Apart from that: Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |