lkml.org 
[lkml]   [2014]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 3/4] ARM: dts: keystone: add DT bindings for PCI controller for port 0
On 10/29/2014 09:45 AM, Murali Karicheri wrote:
> Add common DT bindings to support PCI controller driver for port 0 on all of
> the K2 SoCs that has Synopsis Designware based pcie h/w.
>
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> CC: Santosh Shilimkar <ssantosh@kernel.org>
> CC: Rob Herring <robh+dt@kernel.org>
> CC: Pawel Moll <pawel.moll@arm.com>
> CC: Mark Rutland <mark.rutland@arm.com>
> CC: Ian Campbell <ijc+devicetree@hellion.org.uk>
> CC: Kumar Gala <galak@codeaurora.org>
> CC: Russell King <linux@arm.linux.org.uk>
> CC: devicetree@vger.kernel.org
> ---
> v1 - fixed email ID for Santosh and reworded the commit description a bit to
> be consistent with the subject.
> arch/arm/boot/dts/keystone.dtsi | 45 +++++++++++++++++++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
> diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
> index 5d3e83f..87b2daa 100644
> --- a/arch/arm/boot/dts/keystone.dtsi
> +++ b/arch/arm/boot/dts/keystone.dtsi
> @@ -285,5 +285,50 @@
> #interrupt-cells = <1>;
> ti,syscon-dev = <&devctrl 0x2a0>;
> };
> +
> + pcie@21800000 {
> + compatible = "ti,keystone-pcie", "snps,dw-pcie";
> + clocks = <&clkpcie>;
> + clock-names = "pcie";
> + #address-cells = <3>;
> + #size-cells = <2>;
> + reg = <0x21801000 0x2000>, <0x21800000 0x1000>, <0x02620128 4>;
> + ranges = <0x81000000 0 0 0x23250000 0 0x4000
> + 0x82000000 0 0x50000000 0x50000000 0 0x10000000>;
> +
> + device_type = "pci";
> + num-lanes = <2>;
> +
> + #interrupt-cells = <1>;
> + interrupt-map-mask = <0 0 0 7>;
> + interrupt-map = <0 0 0 1 &pcie_intc0 0>, // INT A
> + <0 0 0 2 &pcie_intc0 1>, // INT B
> + <0 0 0 3 &pcie_intc0 2>, // INT C
> + <0 0 0 4 &pcie_intc0 3>; // INT D
> +
Can you just keep the comments under /* ... * / just to be consistent
across file. Rest of the patch looks fine by me.

Regards,
Santosh


\
 
 \ /
  Last update: 2014-10-29 20:41    [W:1.482 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site