Messages in this thread | | | Date | Wed, 29 Oct 2014 14:50:55 +0800 | From | Huang Rui <> | Subject | Re: [PATCH v3 04/19] usb: dwc3: add disscramble quirk |
| |
Hi Bjorn,
On Tue, Oct 28, 2014 at 10:39:26AM -0600, Bjorn Helgaas wrote: > On Tue, Oct 28, 2014 at 5:54 AM, Huang Rui <ray.huang@amd.com> wrote: > > This patch adds disscramble quirk, and it only needs to be enabled at fpga > > "disscramble" (in subject and above) is not a real word. > > I see that DWC3_GCTL_DISSCRAMBLE is already defined in > drivers/usb/dwc3/core.h even before your patches, so I suppose it's > something the hardware designers made up. > > Maybe it means "descramble" (or "unscramble"). Or maybe it means > "disable scrambling"? A comment might make this clearer. A better > name would be even better. >
Your mention is right. "disscramble" is writed by HW designers in DesignWare databook. It could confuse reader, I will update subject and add note (disscramble = disable scramble) at commit log.
Thanks, Rui
| |