lkml.org 
[lkml]   [2014]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/11] irqchip: bcm7120-l2: Fix missing nibble in gc->unused mask
On 10/28/2014 08:58 PM, Kevin Cernekee wrote:
> This mask should have been 0xffff_ffff, not 0x0fff_ffff.
>
> The change should not have an effect on current users (STB) because bits
> 31:27 are unused.

Nice catch!

>
> Signed-off-by: Kevin Cernekee <cernekee@gmail.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

> ---
> drivers/irqchip/irq-bcm7120-l2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-bcm7120-l2.c b/drivers/irqchip/irq-bcm7120-l2.c
> index f041992..e9331f8 100644
> --- a/drivers/irqchip/irq-bcm7120-l2.c
> +++ b/drivers/irqchip/irq-bcm7120-l2.c
> @@ -171,7 +171,7 @@ int __init bcm7120_l2_intc_of_init(struct device_node *dn,
> }
>
> gc = irq_get_domain_generic_chip(data->domain, 0);
> - gc->unused = 0xfffffff & ~data->irq_map_mask;
> + gc->unused = 0xffffffff & ~data->irq_map_mask;
> gc->reg_base = data->base;
> gc->private = data;
> ct = gc->chip_types;
>



\
 
 \ /
  Last update: 2014-10-29 18:01    [W:0.732 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site