Messages in this thread | | | Date | Wed, 29 Oct 2014 18:16:18 +0200 | Subject | Re: [patch] iwlwifi: cleanup a mask shift in iwlagn_bt_traffic_is_sco() | From | Emmanuel Grumbach <> |
| |
On Wed, Oct 29, 2014 at 6:08 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > The shift operation is higher precedence so the code is wrong and it > sets of a static checker warning. But it doesn't affect real life > because BT_UART_MSG_FRAME3SCOESCO_POS is zero so the shift is a no-op. > > I have re-written it in normal style and with parenthesis as a cleanup > and to silence the static checker warning. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> >
In my tree already - I got it from Joe.
https://git.kernel.org/cgit/linux/kernel/git/iwlwifi/iwlwifi-next.git/commit/?id=50f6635afe565a0e1c5ab78f040294fe1dc41de0
| |