Messages in this thread | | | Date | Wed, 29 Oct 2014 12:30:05 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] Add ltc3562 voltage regulator driver |
| |
On Wed, Oct 29, 2014 at 09:16:00AM +0100, Mike Looijmans wrote:
> + if (!status->voltage_set) { > + if (of_property_read_u32(dev->dev.of_node, > + "ltc3562-default-voltage", &v_default) == 0) {
A couple of problems here:
- This contains DT code but no DT bindings documentation; the binding documentation is mandatory for any new bindings. - It's not obvious why a "default voltage" property would be device specific - what is this for and why is it being added in an individual device driver? [unhandled content-type:application/pgp-signature] | |