| Date | Wed, 29 Oct 2014 10:07:32 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 04/16] perf tools: Add a thread stack for synthesizing call chains |
| |
On Thu, Oct 23, 2014 at 01:45:12PM +0300, Adrian Hunter wrote:
SNIP
> }; > > +enum { > + PERF_FLAG_BRANCH = 1ULL << 0, > + PERF_FLAG_CALL = 1ULL << 1, > + PERF_FLAG_RETURN = 1ULL << 2, > + PERF_FLAG_CONDITIONAL = 1ULL << 3, > + PERF_FLAG_SYSCALLRET = 1ULL << 4, > + PERF_FLAG_ASYNC = 1ULL << 5, > + PERF_FLAG_INTERRUPT = 1ULL << 6, > + PERF_FLAG_TX_ABORT = 1ULL << 7, > + PERF_FLAG_TRACE_BEGIN = 1ULL << 8, > + PERF_FLAG_TRACE_END = 1ULL << 9, > + PERF_FLAG_IN_TX = 1ULL << 10, > +}; > + > +#define PERF_BRANCH_MASK (\ > + PERF_FLAG_BRANCH |\ > + PERF_FLAG_CALL |\ > + PERF_FLAG_RETURN |\ > + PERF_FLAG_CONDITIONAL |\ > + PERF_FLAG_SYSCALLRET |\ > + PERF_FLAG_ASYNC |\ > + PERF_FLAG_INTERRUPT |\ > + PERF_FLAG_TX_ABORT |\ > + PERF_FLAG_TRACE_BEGIN |\ > + PERF_FLAG_TRACE_END)
PERF_FLAG_ prefix seems too generic,
should it be something like PERF_BRANCH_FLAG__* ?
jirka
|