Messages in this thread Patch in this message | | | Date | Wed, 29 Oct 2014 11:43:25 +0300 | From | Dan Carpenter <> | Subject | [patch] goldfish: off by one in goldfish_tty_console_setup() |
| |
The goldfish_ttys[] array has "goldfish_tty_line_count" number of elements. It's allocated in goldfish_tty_create_driver(). This test should be >= instead of >.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c index 09495f5..2f68540 100644 --- a/drivers/tty/goldfish.c +++ b/drivers/tty/goldfish.c @@ -155,7 +155,7 @@ static struct tty_driver *goldfish_tty_console_device(struct console *c, static int goldfish_tty_console_setup(struct console *co, char *options) { - if ((unsigned)co->index > goldfish_tty_line_count) + if ((unsigned)co->index >= goldfish_tty_line_count) return -ENODEV; if (goldfish_ttys[co->index].base == 0) return -ENODEV;
| |