lkml.org 
[lkml]   [2014]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/2] mtd: hisilicon: add a new NAND controller driver for hisilicon hip04 Soc
On 2014年10月28日 22:22, Frans Klaver wrote:
> On Tue, Oct 28, 2014 at 11:53 AM, Zhou Wang <wangzhou.bry@gmail.com> wrote:
>> +
>> +static int hisi_nfc_probe(struct platform_device *pdev)
>> +{
>> + int ret = 0, irq, buswidth, flag, max_chips = HINFC504_MAX_CHIP;
>> + struct device *dev = &pdev->dev;
>> + struct hinfc_host *host;
>> + struct nand_chip *chip;
>> + struct mtd_info *mtd;
>> + struct resource *res;
>> + struct device_node *np = dev->of_node;
>> + struct mtd_part_parser_data ppdata;
>> +
>> + host = devm_kzalloc(dev, sizeof(*host), GFP_KERNEL);
>> + if (!host)
>> + return -ENOMEM;
>> + host->dev = dev;
>> +
>> + platform_set_drvdata(pdev, host);
>> + chip = &host->chip;
>> + mtd = &host->mtd;
>> +
>> + irq = platform_get_irq(pdev, 0);
>> + if (irq < 0) {
>> + dev_err(dev, "no IRQ resource defined\n");
>> + ret = -ENXIO;
>> + goto err_res;
>> + }
>> +
>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> + host->iobase = devm_ioremap_resource(dev, res);
>> + if (IS_ERR(host->iobase)) {
>> + ret = PTR_ERR(host->iobase);
>> + dev_err(dev, "devm_ioremap_resource[0] fail\n");
>> + goto err_res;
>> + }
>> +
>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
>> + chip->IO_ADDR_R = chip->IO_ADDR_W = devm_ioremap_resource(dev, res);
>> + if (IS_ERR(chip->IO_ADDR_R)) {
>> + ret = PTR_ERR(chip->IO_ADDR_R);
>> + dev_err(dev, "devm_ioremap_resource[1] fail\n");
>> + goto err_res;
>> + }
>> +
>> + mtd->priv = chip;
>> + mtd->owner = THIS_MODULE;
>> + mtd->name = "hisi_nand";
>
> + mtd->dev.parent = &pdev->dev;
>
> This is a bug that lives in a bunch of other nand drivers as well.
> add_mtd_device (called by mtd_device_parse_register()) expects
> dev.parent to be set for properly adding a device reference to the
> sysfs node.
>
> Frans
>
My mistake, I will add this line. Thanks a lot for your reminding.

Kind regards,
Zhou Wang

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-10-30 04:01    [W:0.089 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site