Messages in this thread | | | Date | Tue, 28 Oct 2014 11:26:39 -0600 | From | Jens Axboe <> | Subject | Re: [PATCH v3] block: wrong return value |
| |
On 2014-10-28 11:22, Sudip Mukherjee wrote: > On Thu, Oct 23, 2014 at 10:16:48PM +0530, Sudip Mukherjee wrote: >> while compiling integer err was showing as a set but unused variable. >> elevator_init_fn can be either cfq_init_queue or deadline_init_queue >> or noop_init_queue. >> all three of these functions are returning -ENOMEM if they fail to >> allocate the queue. >> so we should actually be returning the error code rather than >> returning 0 always. > i have one doubt. shouldn't this patch be marked for stable also?
It would not hurt to mark it as stable, but on the other hand, this probably never triggered a problem for anyone. So it's not a critical fix by any stretch.
-- Jens Axboe
| |