lkml.org 
[lkml]   [2014]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v7 4/7] ARM: dts: Enable Broadcom Cygnus SoC
Date
On Wednesday 22 October 2014 13:57:51 Scott Branden wrote:
> +
> + aliases {
> + serial0 = &uart3;
> + serial1 = &uart0;
> + };
> +
> + chosen {
> + bootargs = "console=ttyS0,115200 earlyprintk debug";
> + };
>

Please move the 'aliases' and 'chosen' node into the .dts files, these
are board specific, not SoC specific.

For chosen, please remove earlyprintk and debug, which don't normally
make sense unless you are debugging, and which will break in a multiplatform
kernel.

Please also add an "stdout-path = &uart3" property in chosen so that
earlycon can work. Note that earlycon is currently broken on arm32,
but we'll get there.

Arnd


\
 
 \ /
  Last update: 2014-10-28 17:41    [W:0.099 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site