Messages in this thread | | | Date | Tue, 28 Oct 2014 11:42:41 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 6/7] debugfs: Fix misuse of seq_printf return value |
| |
On Tue, 28 Oct 2014 08:25:51 -0700 Joe Perches <joe@perches.com> wrote:
> On Tue, 2014-10-28 at 10:58 -0400, Steven Rostedt wrote: > > On Mon, 29 Sep 2014 16:08:26 -0700 > > Joe Perches <joe@perches.com> wrote: > > > Adding repeated -1 to the return is not correct. > > > Use seq_is_full to test for unnecessary seq_printf uses > > > and always return 0. > [] > > Actually, debugfs_print_regs32() should return void as well. > > I'll update that. > > Great though this should possibly be another patch.
Could have, but other patches that had functions returning the value of seq_printf() also changed their output with the change. Don't worry about being blamed, I update the change log to show that I modified it too. ;-)
> > I didn't want to update the documentation.
It was a one liner, that didn't really change the content.
> > Maybe remove the prototype and make it static too. >
Now that can be a separate patch set if you want. I'm not too worried about that as it doesn't affect the updates I want to do with seq_file.
-- Steve
| |