Messages in this thread | | | Date | Tue, 28 Oct 2014 10:43:12 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 5/7] fs: Convert show_fdinfo functions to void |
| |
On Tue, 28 Oct 2014 07:31:32 -0700 Joe Perches <joe@perches.com> wrote:
> > I wouldn't change logic on this. There's no reason to call this > > function if it isn't doing anything. > > > > I'll change this to just do the update and not change logic like this. > > Fewer #ifdefs >
And there's other ways to fix it (like using an #else), but that is off-topic to the current change set. In other words, that change should be separate, as I don't want discussions on what's the best use of #ifdefs distracting from getting in the "void seq_printf()" changes.
-- Steve
| |