lkml.org 
[lkml]   [2014]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/7] fs: Convert show_fdinfo functions to void
On Tue, 28 Oct 2014 07:31:32 -0700
Joe Perches <joe@perches.com> wrote:


> > I wouldn't change logic on this. There's no reason to call this
> > function if it isn't doing anything.
> >
> > I'll change this to just do the update and not change logic like this.
>
> Fewer #ifdefs
>

And there's other ways to fix it (like using an #else), but that is
off-topic to the current change set. In other words, that change should
be separate, as I don't want discussions on what's the best use of
#ifdefs distracting from getting in the "void seq_printf()" changes.

-- Steve



\
 
 \ /
  Last update: 2014-10-28 16:21    [W:0.083 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site