Messages in this thread |  | | Date | Mon, 27 Oct 2014 22:31:40 -0700 | From | Darren Hart <> | Subject | Re: [PATCH 7/8] eeepc-laptop: document fan_pwm conversions |
| |
On Wed, Oct 22, 2014 at 09:12:42PM +0200, Frans Klaver wrote: > eeepc_get_fan_pwm and eeepc_set_fan_pwm convert the PWM value read from > the fan to a range lmsensors understands. Unfortunately this is only > clear if you are familiar with how lmsensors handles duty cycles. > > Introduce two conversion functions that document the goal of these > conversions. > > Signed-off-by: Frans Klaver <fransklaver@gmail.com> > --- > drivers/platform/x86/eeepc-laptop.c | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c > index f820bb3..275a239 100644 > --- a/drivers/platform/x86/eeepc-laptop.c > +++ b/drivers/platform/x86/eeepc-laptop.c > @@ -974,18 +974,28 @@ static struct platform_driver platform_driver = { > #define EEEPC_EC_SFB0 0xD0 > #define EEEPC_EC_FAN_CTRL (EEEPC_EC_SFB0 + 3) /* Byte containing SF25 */ > > +static inline int eeepc_pwm_to_lmsensors(int value) > +{ > + return value * 255 / 100; > +} > + > +static inline int eeepc_lmsensors_to_pwm(int value) > +{ > + value = clamp_val(value, 0, 255); > + return value * 100 / 255;
Says the guy cleaning up all the magic numbers.... ;-)
But yeah, this is fine IMO. Applied.
-- Darren Hart Intel Open Source Technology Center
|  |