Messages in this thread |  | | From | Andi Kleen <> | Subject | Re: [PATCH 0/4] Convert khugepaged to a task_work function | Date | Tue, 28 Oct 2014 05:12:26 -0700 |
| |
Alex Thorlton <athorlton@sgi.com> writes:
> Last week, while discussing possible fixes for some unexpected/unwanted behavior > from khugepaged (see: https://lkml.org/lkml/2014/10/8/515) several people > mentioned possibly changing changing khugepaged to work as a task_work function > instead of a kernel thread. This will give us finer grained control over the > page collapse scans, eliminate some unnecessary scans since tasks that are > relatively inactive will not be scanned often, and eliminate the unwanted > behavior described in the email thread I mentioned.
With your change, what would happen in a single threaded case?
Previously one core would scan and another would run the workload. With your change both scanning and running would be on the same core.
Would seem like a step backwards to me.
-Andi
-- ak@linux.intel.com -- Speaking for myself only
|  |