lkml.org 
[lkml]   [2014]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.17 014/146] fs: Add a missing permission check to do_umount
    Date
    3.17-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Andy Lutomirski <luto@amacapital.net>

    commit a1480dcc3c706e309a88884723446f2e84fedd5b upstream.

    Accessing do_remount_sb should require global CAP_SYS_ADMIN, but
    only one of the two call sites was appropriately protected.

    Fixes CVE-2014-7975.

    Signed-off-by: Andy Lutomirski <luto@amacapital.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/namespace.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/fs/namespace.c
    +++ b/fs/namespace.c
    @@ -1356,6 +1356,8 @@ static int do_umount(struct mount *mnt,
    * Special case for "unmounting" root ...
    * we just try to remount it readonly.
    */
    + if (!capable(CAP_SYS_ADMIN))
    + return -EPERM;
    down_write(&sb->s_umount);
    if (!(sb->s_flags & MS_RDONLY))
    retval = do_remount_sb(sb, MS_RDONLY, NULL, 0);



    \
     
     \ /
      Last update: 2014-10-28 09:41    [W:3.682 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site