lkml.org 
[lkml]   [2014]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.16 026/127] regmap: fix possible ZERO_SIZE_PTR pointer dereferencing error.
    Date
    3.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Xiubo Li <Li.Xiubo@freescale.com>

    commit d6b41cb06044a7d895db82bdd54f6e4219970510 upstream.

    Since we cannot make sure the 'val_count' will always be none zero
    here, and then if it equals to zero, the kmemdup() will return
    ZERO_SIZE_PTR, which equals to ((void *)16).

    So this patch fix this with just doing the zero check before calling
    kmemdup().

    Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/base/regmap/regmap.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/base/regmap/regmap.c
    +++ b/drivers/base/regmap/regmap.c
    @@ -1646,6 +1646,9 @@ out:
    } else {
    void *wval;

    + if (!val_count)
    + return -EINVAL;
    +
    wval = kmemdup(val, val_count * val_bytes, GFP_KERNEL);
    if (!wval) {
    dev_err(map->dev, "Error in memory allocation\n");



    \
     
     \ /
      Last update: 2014-10-28 09:01    [W:2.580 / U:0.768 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site