Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH v3 1/2] PM / Sleep: fix async suspend_late/freeze_late error handling | Date | Mon, 27 Oct 2014 23:45:30 +0100 |
| |
On Friday, October 24, 2014 08:29:09 PM Imre Deak wrote: > If an asynchronous suspend_late or freeze_late callback fails > during the SUSPEND, FREEZE or QUIESCE phases we don't propagate the > corresponding error correctly, in effect ignoring the error and > continuing the suspend-to-ram/hibernation. During suspend-to-ram this > could leave some devices without a valid saved context, leading to a > failure to reinitialize them during resume. During hibernation this > could leave some devices active interfeering with the creation / > restoration of the hibernation image. Also this could leave the > corresponding devices without a valid saved context and failure to > reinitialize them during resume. > > v3 (added to patchset): > - split out this fix into a separate patch (Rafael) > > Signed-off-by: Imre Deak <imre.deak@intel.com>
Both [1-2/2] applied, thanks!
> --- > drivers/base/power/main.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c > index 4497319..9717d5f 100644 > --- a/drivers/base/power/main.c > +++ b/drivers/base/power/main.c > @@ -1266,6 +1266,8 @@ int dpm_suspend_late(pm_message_t state) > } > mutex_unlock(&dpm_list_mtx); > async_synchronize_full(); > + if (!error) > + error = async_error; > if (error) { > suspend_stats.failed_suspend_late++; > dpm_save_failed_step(SUSPEND_SUSPEND_LATE); >
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |