Messages in this thread | | | Date | Mon, 27 Oct 2014 14:14:44 -0500 | From | Suravee Suthikulanit <> | Subject | Re: [PATCH V2] arm64: amd-seattle: Adding device tree for AMD Seattle platform |
| |
On 10/27/2014 2:07 PM, Arnd Bergmann wrote: > On Monday 27 October 2014 13:54:25 suravee.suthikulpanit@amd.com wrote: >> + sata0: sata@00300000 { >> + compatible = "snps,spear-ahci"; >> + reg = <0 0x300000 0 0x800>; >> + interrupts = <0 355 4>; >> + clocks = <&sataclk_333mhz>; >> + clock-names = "apb_pclk"; >> + dma-coherent; >> + }; > > Please use "snps,dwc-ahci" as the compatible string for a designware > ahci controller, not "snps,spear-ahci", which refers to the implementation > of that in the ST microelectronics SPEAr consumer SoC. > > It would be good to also add a string that is specific for your SoC if > we ever need to identify it directly. > > Arnd >
Thanks. I will update this in V3.
Suravee
| |