Messages in this thread | | | Date | Mon, 27 Oct 2014 19:32:33 +0100 | From | Sebastian Reichel <> | Subject | Re: [PATCH v2 2/2] power: charger-manager: Avoid recursive thermal get_temp call |
| |
Hi,
On Tue, Oct 07, 2014 at 05:47:37PM +0200, Krzysztof Kozlowski wrote: > The charger manager supports POWER_SUPPLY_PROP_TEMP property and acts > as a thermal zone if any of these conditions match: > 1. Fuel gauge used by charger manager supports POWER_SUPPLY_PROP_TEMP. > 2. 'cm-thermal-zone' property is present in DTS (then it will supersede > the fuel gauge temperature property). > > However in case 1 (fuel gauge reports temperature and 'cm-thermal-zone' > is not set) the charger manager forwards its get_temp calls to fuel > gauge thermal zone. > > This leads to reporting by lockdep a false positive deadlock for thermal > zone's mutex because of nested calls to thermal_zone_get_temp(). This is > false positive because these are different mutexes: one for charger > manager thermal zone and second for fuel gauge thermal zone. > > Get rid of false lockdep alert and recursive call by setting > 'no_thermal' property for this power supply class. The thermal zone for > charger manager won't be created (user space does not use it anyway).
also pulled into next, will also be included in 3.18-rc pull request.
-- Sebastian [unhandled content-type:application/pgp-signature] | |