Messages in this thread | | | Date | Mon, 27 Oct 2014 18:43:38 +0100 | From | Sebastian Reichel <> | Subject | Re: [PATCH v2 1/2] power: bq2415x_charger: Properly handle ENODEV from power_supply_get_by_phandle |
| |
Hi,
On Wed, Oct 15, 2014 at 04:25:09PM +0200, Krzysztof Kozlowski wrote: > The power_supply_get_by_phandle() on error returns ENODEV or NULL. > The driver later expects obtained pointer to power supply to be > valid or NULL. If it is not NULL then it dereferences it in > bq2415x_notifier_call() which would lead to dereferencing ENODEV-value > pointer. > > Properly handle the power_supply_get_by_phandle() error case by > replacing error value with NULL. This indicates that usb charger > detection won't be used. > > Fix also memory leak of 'name' if power_supply_get_by_phandle() fails > with NULL and probe should defer.
Applied to next.
-- Sebastian [unhandled content-type:application/pgp-signature] | |