lkml.org 
[lkml]   [2014]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v7 5/8] xen/arm: use is_device_dma_coherent
    Date
    Use is_device_dma_coherent to check whether we need to issue cache
    maintenance operations rather than checking on the existence of a
    particular dma_ops function for the device.

    This is correct because coherent devices don't need cache maintenance
    operations - arm_coherent_dma_ops does not set the hooks that we
    were previously checking for existance.

    Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    ---
    arch/arm/xen/mm32.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/arch/arm/xen/mm32.c b/arch/arm/xen/mm32.c
    index 6153d61..d8ed359 100644
    --- a/arch/arm/xen/mm32.c
    +++ b/arch/arm/xen/mm32.c
    @@ -76,7 +76,7 @@ void xen_dma_unmap_page(struct device *hwdev, dma_addr_t handle,
    struct dma_attrs *attrs)

    {
    - if (!__generic_dma_ops(hwdev)->unmap_page)
    + if (is_device_dma_coherent(hwdev))
    return;
    if (dma_get_attr(DMA_ATTR_SKIP_CPU_SYNC, attrs))
    return;
    @@ -87,7 +87,7 @@ void xen_dma_unmap_page(struct device *hwdev, dma_addr_t handle,
    void xen_dma_sync_single_for_cpu(struct device *hwdev,
    dma_addr_t handle, size_t size, enum dma_data_direction dir)
    {
    - if (!__generic_dma_ops(hwdev)->sync_single_for_cpu)
    + if (is_device_dma_coherent(hwdev))
    return;
    __xen_dma_page_dev_to_cpu(hwdev, handle, size, dir);
    }
    @@ -95,7 +95,7 @@ void xen_dma_sync_single_for_cpu(struct device *hwdev,
    void xen_dma_sync_single_for_device(struct device *hwdev,
    dma_addr_t handle, size_t size, enum dma_data_direction dir)
    {
    - if (!__generic_dma_ops(hwdev)->sync_single_for_device)
    + if (is_device_dma_coherent(hwdev))
    return;
    __xen_dma_page_cpu_to_dev(hwdev, handle, size, dir);
    }
    --
    1.7.10.4


    \
     
     \ /
      Last update: 2014-10-27 16:41    [W:5.154 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site