Messages in this thread | | | Date | Mon, 27 Oct 2014 15:48:42 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH 0/4] Attempt to cleanup the HSW offcore bits |
| |
On Mon, Oct 27, 2014 at 07:28:18AM -0700, Andi Kleen wrote: > On Mon, Oct 27, 2014 at 02:07:12PM +0100, Peter Zijlstra wrote: > > On Mon, Oct 27, 2014 at 01:23:40PM +0100, Andi Kleen wrote: > > > On Thu, Oct 23, 2014 at 12:51:19PM +0200, Peter Zijlstra wrote: > > > > So Don asked about offcore and because I forgot I looked at the code and found > > > > the terrible mess Andi created with the HSW/BDW bits. > > > > > > > > This series attempts to clean some of that up but seeing how it was all magic > > > > numbers > > > > > > All the bits are documented. The actual definitions are available > > > in the JSON offcore definitions at https://download.01.org/perfmon/ > > > > Yeah, no. That's not how we write code. Also, there's no actual JSON > > offcore file for HSW only some TSV file, and I've no mind to go decode > > https://download.01.org/perfmon/HSW/Haswell_matrix_V14.json > https://download.01.org/perfmon/HSW/Haswell_matrix_bit_definitions_V14.json
So you expected me to somehow magically know it was not the file with offcore in its name then?
| |