Messages in this thread | | | Date | Mon, 27 Oct 2014 14:39:49 +0100 | From | Javier Martinez Canillas <> | Subject | Re: [PATCH v5 3/4] regulator: max77686: Add suspend disable for some LDOs |
| |
Hello Krzysztof,
On 10/27/2014 01:11 PM, Krzysztof Kozlowski wrote: > Some LDOs of Maxim 77686 PMIC support disabling during system suspend > (LDO{2,6,7,8,10,11,12,14,15,16}). This was already implemented as part > of set_suspend_mode function. In that case the mode was one of: > - disable, > - normal mode, > - low power mode. > However there are no bindings for setting the mode during suspend. > > Add suspend disable for LDO regulators supporting this. Re-use existing > max77686_buck_set_suspend_disable() function. This helps reducing > energy consumption during system sleep. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- > drivers/regulator/max77686.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/drivers/regulator/max77686.c b/drivers/regulator/max77686.c > index 2ebc4257425b..c6bf6f79bd2a 100644 > --- a/drivers/regulator/max77686.c > +++ b/drivers/regulator/max77686.c
Looks good to me.
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards, Javier
| |