Messages in this thread |  | | Date | Mon, 27 Oct 2014 15:52:48 +0300 | From | Dan Carpenter <> | Subject | Re: [RFC 2/2] staging: ion: debugfs to shrink pool |
| |
On Mon, Oct 27, 2014 at 02:42:40PM +0300, Dan Carpenter wrote: > On Thu, Oct 23, 2014 at 09:52:20PM +0900, Gioh Kim wrote: > > This patch creates debugfs files, /sys/kernel/debug/ion/heaps/system_shrink, > > to shrink pool or get pool size. > > Reading the file returns pool size and writing occurs to shrink pool. > > The patch looks fine. Of course, the original code was debugfs before > it bitrotted and stopped compiling, but is there there a reason why we > shouldn't move this to sysfs instead? Just curious. >
I read the Laura's review comments and it turns out we don't want this enabled by default and debugfs is fine. Question answered.
regards, dan carpenter
|  |