Messages in this thread | | | Date | Mon, 27 Oct 2014 14:53:17 +0530 | From | Srikar Dronamraju <> | Subject | Re: [PATCH] sched:skip loop non-idle cpus after find an idle cpu while find_idlest_cpu |
| |
* Yao Dongdong <yaodongdong@huawei.com> [2014-10-27 16:58:05]:
> On 2014/10/27 16:04, Srikar Dronamraju wrote: > > * Yao Dongdong <yaodongdong@huawei.com> [2014-10-27 11:13:17]: > > > >> Idle cpu is idler than non-idle cpu, so we needn't loop non-idle cpus after find an idle cpu. > >> > > While this check looks good, > > I dont see how we are avoiding a loop? > > > > Are you suggesting that we break of the for loop once we set > > shallowest_idle_cpu? > > > Thanks for your review. > > I agree that the submit message is a bit misleading, what this patch do is just avoiding search for least_loaded_cpu > in non-idle cpus. > > sched:add check of shallowest_idle_cpu before search for least_loaded_cpu > > Idle cpu is idler than non-idle cpu, so we needn't search for least_loaded_cpu > after we have found an idle cpu. >
Looks good for me.
Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
-- Thanks and Regards Srikar Dronamraju
| |