Messages in this thread | | | Date | Mon, 27 Oct 2014 13:34:22 +0530 | From | Srikar Dronamraju <> | Subject | Re: [PATCH] sched:skip loop non-idle cpus after find an idle cpu while find_idlest_cpu |
| |
* Yao Dongdong <yaodongdong@huawei.com> [2014-10-27 11:13:17]:
> Idle cpu is idler than non-idle cpu, so we needn't loop non-idle cpus after find an idle cpu. >
While this check looks good, I dont see how we are avoiding a loop?
Are you suggesting that we break of the for loop once we set shallowest_idle_cpu?
-- Thanks and Regards Srikar
> Signed-off-by:yaodongdong@huawei.com > > --- > kernel/sched/fair.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 0b069bf..2445a23 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -4446,7 +4446,7 @@ find_idlest_cpu(struct sched_group *group, struct task_struct *p, int this_cpu) > latest_idle_timestamp = rq->idle_stamp; > shallowest_idle_cpu = i; > } > - } else { > + } else if (shallowest_idle_cpu == -1) { > load = weighted_cpuload(i); > if (load < min_load || (load == min_load && i == this_cpu)) { > min_load = load; > -- > 1.8.0.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
-- Thanks and Regards Srikar Dronamraju
| |