Messages in this thread | | | Date | Mon, 27 Oct 2014 23:11:15 -0400 | Subject | Re: [RFD PATCH 02/10] cpuidle: Checking the zero latency inside the governors does not make sense. | From | Len Brown <> |
| |
after the patch '[V2,1/5] sched: idle: cpuidle: Check the latency req before idle' is applied, this one becomes a no-op.
indeed, they'd conflict both logically and physically. physically the check for latency_req == 0 was already removed from the governors. logically, the upper level, cpu_idle_loop() already invokes cpu_idle_poll() directly when latency_req is 0. Indeed, that would prevent the code in this patch from running at all, since cpu_idle_call() is no longer invoked in that case. Further, why would you propose invoking "use_default" instead of cpu_idle_poll() in the latency_req == 0 case?
thanks, Len Brown, Intel Open Source Technology Center
| |