lkml.org 
[lkml]   [2014]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [RFD PATCH 02/10] cpuidle: Checking the zero latency inside the governors does not make sense.
    From
    after the patch '[V2,1/5] sched: idle: cpuidle: Check the latency req
    before idle' is applied,
    this one becomes a no-op.

    indeed, they'd conflict both logically and physically.
    physically the check for latency_req == 0 was already removed from the
    governors.
    logically, the upper level, cpu_idle_loop() already invokes
    cpu_idle_poll() directly
    when latency_req is 0. Indeed, that would prevent the code in this
    patch from running
    at all, since cpu_idle_call() is no longer invoked in that case.
    Further, why would
    you propose invoking "use_default" instead of cpu_idle_poll() in the
    latency_req == 0 case?

    thanks,
    Len Brown, Intel Open Source Technology Center


    \
     
     \ /
      Last update: 2014-10-28 04:41    [W:4.623 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site