lkml.org 
[lkml]   [2014]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/10] uprobes: share the i_mmap_rwsem
On 10/27, Srikar Dronamraju wrote:
>
> Copying Oleg (since he should have been copied on this one)

Thanks ;)

> Please see one comment below.
>
> Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
>
> > ---
> > kernel/events/uprobes.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
> > index 045b649..7a9e620 100644
> > --- a/kernel/events/uprobes.c
> > +++ b/kernel/events/uprobes.c
> > @@ -724,7 +724,7 @@ build_map_info(struct address_space *mapping, loff_t offset, bool is_register)
> > int more = 0;
> >
> > again:
> > - i_mmap_lock_write(mapping);
> > + i_mmap_lock_read(mapping);

I too think the patch is fine.

I didn't see other changes, but I hope that i_mmap_lock_write/read names
provide enough info and ->i_mmap_mutex was turned into rw-lock, in this
case read-lock should be enough.

Oleg.



\
 
 \ /
  Last update: 2014-10-28 02:21    [W:1.858 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site