lkml.org 
[lkml]   [2014]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC 4/7] soc: qcom: Add Shared Memory Manager driver
On Wed 08 Oct 14:33 PDT 2014, Jeffrey Hugo wrote:

[..]
> > + */
> > +struct smem_header {
> > + struct smem_proc_comm proc_comm[4];
> > + u32 version[32];
> > + u32 smem_initialized;
> > + u32 free_offset;
> > + u32 available;
> > + u32 unused;
>
> I see that you inlined the smem_heap_info struct. That is slightly
> problematic since we have some uses of that structure, and without it,
> accessing id 1 becomes complicated. I would prefer you reintroduce it.
>

Could you help me better understand what you mean here? I've scanned through
msm-3.4 and msm-3.10 and read your comment numerous times, but I can't find any
uses that needs it nor figure out why it would be difficult to access item 1.

> > + struct smem_entry toc[SMEM_MAX_ITEMS];
> > +};

Thanks,
Bjorn


\
 
 \ /
  Last update: 2014-10-28 01:41    [W:0.085 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site