lkml.org 
[lkml]   [2014]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] netlink: don't copy over empty attribute data
    From
    From: Sasha Levin <sasha.levin@oracle.com>
    Date: Sun, 26 Oct 2014 19:32:42 -0400

    > How so? GCC states clearly that you should *never* pass a NULL
    > pointer there:
    >
    > "The pointers passed to memmove (and similar functions in <string.h>) must
    > be non-null even when nbytes==0" (https://gcc.gnu.org/gcc-4.9/porting_to.html).
    >
    > Even if it doesn't dereference it, it can break somehow in a subtle way. Leaving
    > the kernel code assuming that gcc (or any other compiler) would always behave
    > the same in a situation that shouldn't occur.

    Show me a legal way in which one could legally dereference the pointer
    when length is zero, and I'll entertain this patch.


    \
     
     \ /
      Last update: 2014-10-27 03:41    [W:2.867 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site