Messages in this thread | | | Date | Sat, 25 Oct 2014 17:05:51 -0400 (EDT) | Subject | Re: [PATCH v3] drivers: net: xgene: Rewrite buggy loop in xgene_enet_ecc_init() | From | David Miller <> |
| |
From: Geert Uytterhoeven <geert@linux-m68k.org> Date: Thu, 23 Oct 2014 10:25:53 +0200
> drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c: In function ‘xgene_enet_ecc_init’: > drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c:126: warning: ‘data’ may be used uninitialized in this function > > Depending on the arbitrary value on the stack, the loop may terminate > too early, and cause a bogus -ENODEV failure. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > v3: > - Use "do { ... } while (...);" instead of "for (...) { ... }", > v2: > - Rewrite the loop instead of pre-initializing data.
Applied, thank you.
| |