Messages in this thread Patch in this message | | | Date | Fri, 24 Oct 2014 00:55:08 -0700 | From | tip-bot for Kan Liang <> | Subject | [tip:perf/urgent] perf diff: Add missing hists__init() call at tool start |
| |
Commit-ID: 9ab1f50876dbb8b962db058259be7aae920d4c25 Gitweb: http://git.kernel.org/tip/9ab1f50876dbb8b962db058259be7aae920d4c25 Author: Kan Liang <kan.liang@intel.com> AuthorDate: Wed, 22 Oct 2014 15:02:41 -0400 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Wed, 22 Oct 2014 16:31:06 -0300
perf diff: Add missing hists__init() call at tool start
It also uses hists/hist_entries, hists__init() should be called before creating any evsels.
Otherwise no extra space will be allocated per perf_evsel nor this space will be initialized when allocating a new perf_evsel instance, resulting in reads/writes to non allocated space, oops. Fix it.
Signed-off-by: Kan Liang <kan.liang@intel.com> Link: http://lkml.kernel.org/r/1414004561-22096-1-git-send-email-kan.liang@intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/builtin-diff.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c index 8c5c11c..25114c9 100644 --- a/tools/perf/builtin-diff.c +++ b/tools/perf/builtin-diff.c @@ -1142,6 +1142,11 @@ static int data_init(int argc, const char **argv) int cmd_diff(int argc, const char **argv, const char *prefix __maybe_unused) { + int ret = hists__init(); + + if (ret < 0) + return ret; + perf_config(perf_default_config, NULL); argc = parse_options(argc, argv, options, diff_usage, 0);
| |