Messages in this thread | | | Date | Fri, 24 Oct 2014 09:24:45 +0200 | Subject | Re: [GIT PULL] overlay filesystem v25 | From | Miklos Szeredi <> |
| |
On Fri, Oct 24, 2014 at 5:24 AM, Al Viro <viro@zeniv.linux.org.uk> wrote: > On Fri, Oct 24, 2014 at 03:20:55AM +0100, Al Viro wrote: >> Why the hell do you hold ->i_mutex across the entire opening of underlying >> directory? All you need is to serialize one assignment; the side that loses >> the race will simply fput() what it opened...
The reason I didn't do your "fix" is that it
- adds more lines than it takes,
- I wasn't sure at all if the lockless access is actually correct without the ACCESS_ONCE and all the memory barrier magic that might be necessary on weird architectures.
The rest of the changes look OK.
Thanks, Miklos
| |