Messages in this thread | | | Date | Fri, 24 Oct 2014 16:17:13 +0200 | From | Sylwester Nawrocki <> | Subject | Re: [PATCHv2 1/2] clk: samsung: exynos4415: Add clocks using common clock framework |
| |
Hi Chanwoo,
On 24/10/14 16:07, Chanwoo Choi wrote: [...] >> How about prefixing the table names below with "exynos4415", rather than >> "samsung" ? > > 'struct samsung_fixed_factor_clock' is common for Exynos SoC. > > Do you means that add 'exynos4415' prefix as following: > - fixed_factor_clks -> exynos4415_fixed_factor_clks
Yes, it makes sense IMHO, even though those symbols are static. It's done like that in other SoC drivers, e.g. exynos3250.
>>> +static struct samsung_fixed_factor_clock fixed_factor_clks[] __initdata = { >> >>> +}; >>> + >>> +static struct samsung_fixed_rate_clock fixed_rate_clks[] __initdata = { >>> + FRATE(CLK_SCLK_HDMIPHY, "sclk_hdmiphy", NULL, CLK_IS_ROOT, 27000000), >>> +}; >>> + >>> +static struct samsung_mux_clock mux_clks[] __initdata = { >> >>> +}; >>> + >>> +static struct samsung_div_clock div_clks[] __initdata = { >> >>> +}; >>> + >>> +static struct samsung_gate_clock gate_clks[] __initdata = { > > Do you want to change structure naming as following? > fixed_factor_clks -> exynos4415_fixed_factor_clks > fixed_rate_clks -> exynos4415_fixed_rate_clks > mux_clks -> exynos4415_mux_clks > div_clks -> exynos4415_div_clks > gate_clks -> exynos4415_gate_clks
Yes, please.
-- Thanks, Sylwester
| |