Messages in this thread | | | Date | Fri, 24 Oct 2014 15:34:48 +0200 | From | Marek Szyprowski <> | Subject | Re: [PATCH 5/5] ARM: dts: Add dts files for Exynos4415 SoC |
| |
Hello,
On 2014-10-24 15:23, Daniel Drake wrote: > On Sun, Oct 19, 2014 at 9:32 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote: >> This patch adds new exynos4415.dtsi to support Exynos4415 SoC >> based on Cortex-A9 quad cores and includes following dt nodes: > There's a lot in common between your new exynos4415.dtsi and the > existing exynos4.dtsi. > Would it make more sense for the 4415 code to extend the existing > exynos4.dtsi like the other Exynos4 variants do?
Well, I also thought about such approach, but there are some fundamental differences: interrupt and clock controllers are completely different. Using a common exynos4.dtsi and overriding them in every node will result in a code, which is a bit hard to follow. IMHO with such differences justifies using separate base dtsi file.
Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland
| |