Messages in this thread | | | Date | Fri, 24 Oct 2014 14:28:39 +0200 | From | Gregory CLEMENT <> | Subject | Re: [PATCH 2/4] ARM: mvebu: Move SCU power up in a function |
| |
Hi Thomas,
On 24/10/2014 14:19, Thomas Petazzoni wrote: > Dear Gregory CLEMENT, > > On Fri, 24 Oct 2014 14:11:17 +0200, Gregory CLEMENT wrote: > >>> Since this function is not static, I think it might be a good idea to >>> use a prefix that makes it more specific to the platform in order to >>> not pollute the global namespace. Maybe something like >>> 'armada_38x_scu_power_up', or something like that. >> >> Yes given the fact that this function is declared in the mach-mveu folder >> it is sensible to use a more specific name. However the function itself >> is not specific at all to an SoC. This function could be used for any Cortex A9 >> using the SCU. > > Indeed, but as you say, it's right now defined in the mvebu specific > code, so we shouldn't pollute the global namespace. > > Note that there is already a scu_power_mode() that does the same thing,
I know this function: I used it for the idle support.
> but implemented in C, so I'm not sure you can call it at search an early > point.
you meant "such" instead of "search" I guess, and yes unfortunately we can't use a C function at this step.
Gregory
-- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
| |