Messages in this thread | | | Date | Fri, 24 Oct 2014 14:05:51 +0200 | From | Thomas Petazzoni <> | Subject | Re: [PATCH 2/4] ARM: mvebu: Move SCU power up in a function |
| |
Dear Gregory CLEMENT,
On Thu, 23 Oct 2014 20:14:28 +0200, Gregory CLEMENT wrote:
> +ENTRY(power_up_scu) > + mrc p15, 4, r1, c15, c0 @ get SCU base address > + orr r1, r1, #0x8 @ SCU CPU Power Status Register > + mrc 15, 0, r0, cr0, cr0, 5 @ get the CPU ID > + and r0, r0, #15 > + add r1, r1, r0 > + mov r0, #0x0 > + strb r0, [r1] @ switch SCU power state to Normal mode > + ret lr > +ENDPROC(power_up_scu)
Since this function is not static, I think it might be a good idea to use a prefix that makes it more specific to the platform in order to not pollute the global namespace. Maybe something like 'armada_38x_scu_power_up', or something like that.
Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
| |