lkml.org 
[lkml]   [2014]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 03/16] perf session: Add perf_session__deliver_synth_event()
    Date
    On Thu, 23 Oct 2014 13:45:11 +0300, Adrian Hunter wrote:
    > Add a function to deliver synthesized events from
    > within a session.
    >
    > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
    > ---
    > tools/perf/util/session.c | 14 ++++++++++++++
    > tools/perf/util/session.h | 5 +++++
    > 2 files changed, 19 insertions(+)
    >
    > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
    > index d70e37d..09635d1 100644
    > --- a/tools/perf/util/session.c
    > +++ b/tools/perf/util/session.c
    > @@ -907,6 +907,20 @@ static s64 perf_session__process_user_event(struct perf_session *session,
    > }
    > }
    >
    > +int perf_session__deliver_synth_event(struct perf_session *session,
    > + union perf_event *event,
    > + struct perf_sample *sample,
    > + struct perf_tool *tool)
    > +{
    > + events_stats__inc(&session->stats, event->header.type);
    > +
    > + if (event->header.type >= PERF_RECORD_USER_TYPE_START)
    > + return perf_session__process_user_event(session, event, tool,
    > + 0);
    > +
    > + return perf_session__deliver_event(session, event, sample, tool, 0);
    > +}

    It seems that it's basically same as what perf_session__process_event()
    does. So it might deserve a comment or better changelog why it's needed.

    Thanks,
    Namhyung


    > +
    > static void event_swap(union perf_event *event, bool sample_id_all)
    > {
    > perf_event__swap_op swap;
    > diff --git a/tools/perf/util/session.h b/tools/perf/util/session.h
    > index d8521ac..dc26ebf 100644
    > --- a/tools/perf/util/session.h
    > +++ b/tools/perf/util/session.h
    > @@ -127,6 +127,11 @@ extern volatile int session_done;
    >
    > #define session_done() ACCESS_ONCE(session_done)
    >
    > +int perf_session__deliver_synth_event(struct perf_session *session,
    > + union perf_event *event,
    > + struct perf_sample *sample,
    > + struct perf_tool *tool);
    > +
    > int perf_event__process_id_index(struct perf_tool *tool,
    > union perf_event *event,
    > struct perf_session *session);


    \
     
     \ /
      Last update: 2014-10-24 08:01    [W:4.849 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site