Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 01/16] perf tools: Add id index | Date | Fri, 24 Oct 2014 14:10:40 +0900 |
| |
On Thu, 23 Oct 2014 18:08:17 -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Oct 23, 2014 at 01:45:09PM +0300, Adrian Hunter escreveu: >> Add an index of the event identifiers. >> >> This is needed to queue Instruction >> Trace samples according to the mmap >> buffer from which they were recorded. > > This gets difficult to review, I end up having to look at all the > patches together to figure out the use cases, to see if this here makes > sense... > > Can you try to explain like to a seven year old? > > Sigh. > > 'id' is somethig super vague, what does this identifies? I want to make > progress processing these patches, but with so short explanations like > the above one, it gets difficult.
I also often get confused when I saw an id and/or idx. ;-)
Thanks, Namhyung
| |