lkml.org 
[lkml]   [2014]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 4/6] ARM: rockchip: add suspend and resume for RK3288
From
Chris,

On Tue, Oct 21, 2014 at 4:25 PM, Chris Zhong <zyw@rock-chips.com> wrote:
> +static inline void rk3288_copy_data_to_sram(void)
> +{
> + u32 resume_code_size = (u32)&rkpm_bootdata_cpu_code -
> + (u32)rockchip_slp_cpu_resume + 4;
> +
> + /* save root sram data in ddr mem */
> + memcpy(rk3288_bootram_base, bootram_save_data, SZ_4K);

I swore we looked at this before, but the above memcpy is backwards.

> + /* move resume code and data to bootsram */
> + memcpy(rk3288_bootram_base, rockchip_slp_cpu_resume,
> + resume_code_size);
> +}
> +
> +static inline void rk3288_restore_original_sram(void)
> +{
> + memcpy(bootram_save_data, rk3288_bootram_base, SZ_4K);

This one too.


\
 
 \ /
  Last update: 2014-10-24 07:21    [W:0.434 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site