lkml.org 
[lkml]   [2014]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V5] mtd: ubi: Extend UBI layer debug/messaging capabilities
On 2014/10/24 11:33, hujianyang wrote:
>
>> @@ -1798,15 +1803,18 @@ int ubi_thread(void *u)
>> int failures = 0;
>> struct ubi_device *ubi = u;
>>
>> - ubi_msg("background thread \"%s\" started, PID %d",
>> + ubi_msg(ubi, "background thread \"%s\" started, PID %d",
>> ubi->bgt_name, task_pid_nr(current));
>>
>> set_freezable();
>> for (;;) {
>> int err;
>>
>> - if (kthread_should_stop())
>> + if (kthread_should_stop()) {
>> + ubi_msg(ubi, "background thread \"%s\" should stop, PID %d",
>> + ubi->bgt_name, task_pid_nr(current));
>> break;
>> + }
>>
>> if (try_to_freeze())
>> continue;

> @@ -470,8 +470,11 @@ struct ubi_wl_entry *ubi_wl_get_fm_peb(struct ubi_device *ubi, int anchor)
> {
> struct ubi_wl_entry *e = NULL;
>
> - if (!ubi->free.rb_node || (ubi->free_count - ubi->beb_rsvd_pebs < 1))
> + if (!ubi->free.rb_node || (ubi->free_count - ubi->beb_rsvd_pebs < 1)) {
> + ubi_warn(ubi, "Can't get peb for fastmap:anchor=%d, free_cnt=%d, reserved=%d",
> + anchor, ubi->free_count, ubi->beb_rsvd_pebs);
> goto out;
> + }
>
> if (anchor)
> e = find_anchor_wl_entry(&ubi->free);

Sorry, one of the adding messages should be this~!

>
>> @@ -1798,15 +1803,18 @@ int ubi_thread(void *u)
>> int failures = 0;
>> struct ubi_device *ubi = u;
>>
>> - ubi_msg("background thread \"%s\" started, PID %d",
>> + ubi_msg(ubi, "background thread \"%s\" started, PID %d",
>> ubi->bgt_name, task_pid_nr(current));
>>
>> set_freezable();
>> for (;;) {
>> int err;
>>
>> - if (kthread_should_stop())
>> + if (kthread_should_stop()) {
>> + ubi_msg(ubi, "background thread \"%s\" should stop, PID %d",
>> + ubi->bgt_name, task_pid_nr(current));
>> break;
>> + }
>>
>> if (try_to_freeze())
>> continue;
>
> Here are two new adding messages. Maybe a separate patch is better? Just a
> suggestion.
>





\
 
 \ /
  Last update: 2014-10-24 06:21    [W:1.974 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site