Messages in this thread |  | | Date | Fri, 24 Oct 2014 03:20:55 +0100 | From | Al Viro <> | Subject | Re: [GIT PULL] overlay filesystem v25 |
| |
On Fri, Oct 24, 2014 at 01:25:39AM +0200, Miklos Szeredi wrote: > Linus, > > Please pull > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs.v25 > > Plenty of bugs fixed relative to the previous version, thanks to Al Viro's > review and is now officially be BugFree(TM). Also passes the > unionmount-testsuite by David Howells.
*blink*
Why the hell do you hold ->i_mutex across the entire opening of underlying directory? All you need is to serialize one assignment; the side that loses the race will simply fput() what it opened...
Oh, well - that goes under "weird pessimisations, easy to fix in followups"...
|  |