lkml.org 
[lkml]   [2014]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: rcu_preempt detected stalls.
On Thu, Oct 23, 2014 at 11:13:04PM +0200, Oleg Nesterov wrote:
> On 10/23, Paul E. McKenney wrote:
> >
> > Your code, your rules. ;-)
>
> Heh, no. I do not trust my (perverted) taste, I never-never
> argue with cosmetic issues ;)
>
> Cough... and at the same time I have a small nit.

;-) ;-) ;-)

> > But given this structure, why not use a for() loop replace the
> > "goto retry" with an inverted condition and a "return error"?
> > Maybe something like the following patch?
>
> Thanks,
>
> Acked-by: Oleg Nesterov <oleg@redhat.com>

Got it, thank you!

Thanx, Paul



\
 
 \ /
  Last update: 2014-10-24 00:21    [W:0.129 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site