Messages in this thread |  | | Date | Thu, 23 Oct 2014 13:26:41 -0500 | From | Dinh Nguyen <> | Subject | Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role |
| |
On 10/23/2014 01:28 PM, Paul Zimmerman wrote: >> From: Bartlomiej Zolnierkiewicz [mailto:b.zolnierkie@samsung.com] >> Sent: Wednesday, October 22, 2014 5:26 AM >> >> On Monday, October 20, 2014 01:52:06 PM dinguyen@opensource.altera.com wrote: >>> From: Dinh Nguyen <dinguyen@opensource.altera.com> >>> >>> config USB_DWC2_PLATFORM >>> bool "DWC2 Platform" >>> - depends on USB_DWC2_HOST >>> default USB_DWC2_HOST >> >> It should be "default USB_DWC2_HOST || USB_DWC2_PERIPHERAL" because >> USB_DWC2_PLATFORM replaces current USB_DWC2_PERIPHERAL functionality. >> >> Additionaly USB_DWC2_PLATFORM should be changed to tristate >> (USB_DWC2_PERIPHERAL was a tristeate before your changes). > > Dinh, I think this is a good point. Is there any reason why > USB_DWC2_PLATFORM (and USB_DWC2_PCI for that matter) can't be > tristate? That's what DWC3 does. >
Yes, in my v6, I have made this change.
Thanks, Dinh
|  |